Fix grid errors when quantiles falls outside of violin#3254
Merged
thomasp85 merged 3 commits intotidyverse:masterfrom Apr 24, 2019
Merged
Fix grid errors when quantiles falls outside of violin#3254thomasp85 merged 3 commits intotidyverse:masterfrom
thomasp85 merged 3 commits intotidyverse:masterfrom
Conversation
Member
yutannihilation
left a comment
yutannihilation
left a comment
There was a problem hiding this comment.
Generally, seems good.
Co-Authored-By: thomasp85 <thomasp85@gmail.com>
yutannihilation
approved these changes
Apr 24, 2019
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2885
In certain instances quantiles will have
NAcoordinates and the computed aesthetics will not match the number of lines to draw, leading to grid errors