Skip to content

Avoid indexing error when adding an empty guides() specification#3255

Merged
thomasp85 merged 1 commit intotidyverse:masterfrom
thomasp85:error-empty-guides
Apr 24, 2019
Merged

Avoid indexing error when adding an empty guides() specification#3255
thomasp85 merged 1 commit intotidyverse:masterfrom
thomasp85:error-empty-guides

Conversation

@thomasp85
Copy link
Member

Fixes #2914

This PR makes adding an empty guides() a no-op (from the outside look)

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 23, 2019
@thomasp85 thomasp85 requested a review from clauswilke April 23, 2019 09:27
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 merged commit 126d253 into tidyverse:master Apr 24, 2019
@lock
Copy link

lock bot commented Oct 21, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bad error when guides don't have any arguments passed into it

2 participants