Tests to make sure facet_wrap() and facet_grid() can facet by date#3330
Merged
thomasp85 merged 2 commits intotidyverse:v3.2.0-rcfrom May 20, 2019
Merged
Conversation
hadley
approved these changes
May 20, 2019
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions of ggplot2, it was possible to facet by a date variable. This was temporarily broken (#3313) and will be fixed by #3327. It should always be possible to use
facet_wrap()andfacet_grid()with date variables, and as @yutannihilation pointed out, there is no test to enforce this behaviour. This PR adds such a test (there are already similar tests intests/testthat/test-facet-map.r). This test currently fails as #3327 isn't merged.