Improve log validation error formatting with CLI styling #159
Conversation
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Thanks so much for making this happen! Was great to meet you.
These changes seem reasonable, though I'm a bit too scatterbrained post-conf to review thoughtfully at the moment. I'm about to step away from work for 3 weeks—I'll come back to this once I'm back at work!
Safe travels to you on your way back from conf.
|
Sounds good. Was great to meet you too, and have a great vacation! Talk to you in 3 weeks 😄 |
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Loving these changes so much. Thank you!!
Pushing a few edits here in a moment that are mostly style-related; no changes to functionality.
tests/testthat/helper-valid_log.R
Outdated
| "The generated log did not pass the pydantic model:", | ||
| glue::glue("{{.field {result[1]}}}") | ||
| )) | ||
| } else { |
There was a problem hiding this comment.
To simplify this control flow, I am going to remove this else and then return early from the if condition.
tests/testthat/helper-valid_log.R
Outdated
| glue::glue("{{.field {result[1]}}}") | ||
| )) | ||
| } else { | ||
| # Get rid of elements starting with "For further information visit" |
There was a problem hiding this comment.
I will remove most of these "what" comments in favor of one "why" comment
# Make the result more readable by removing redundant elements
# and formatting indices with cli (#159)
2 participants
Simon, I ended up using
cli::format_message()to see cli-styled messages fromtestthat::expect(). One other change I've made since Tidy Dev Day is to account for single-line error messages (i.e.Error: Expecting ',' delimiter: line 165 column 13 (char 3699) with anif elsestatement.Fixes #148