Improve log validation error formatting with CLI styling #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Thanks so much for making this happen! Was great to meet you.
These changes seem reasonable, though I'm a bit too scatterbrained post-conf to review thoughtfully at the moment. I'm about to step away from work for 3 weeks—I'll come back to this once I'm back at work!
Safe travels to you on your way back from conf.
|
Sounds good. Was great to meet you too, and have a great vacation! Talk to you in 3 weeks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simon, I ended up using
cli::format_message()to see cli-styled messages fromtestthat::expect(). One other change I've made since Tidy Dev Day is to account for single-line error messages (i.e.Error: Expecting ',' delimiter: line 165 column 13 (char 3699) with anif elsestatement.Fixes #148