RGL object fetching reworked

[pijaro]

The approach for the system looks as follows:

• Fetch all the scene objects on the initialization, only once,
• Each object spawned on the scene (vehicle or pedestrian) registers itself in the RGL SceneManager.
• Each object despawned from the scene (vehicle or pedestrian) unregisters itself in from the RGL SceneManager.

In a result, there are no frequent fetches of the whole level (FindObjectsOfType).

Requires #148

[mackierx111]

Change to draft until #148 is merged

[mackierx111]

I don't think each NPC class should reference the RGL SceneManager. Is there a problem if the call to SceneManager.RegisterRGL is called by the class that spawns the NPC?

[Goldob]

@mackierx111 CC @pijaro

I apologize for the late response. I see one main issue with this approach, which is that for what I know, NPCPedestrian.cs does not have a spawning class when AWSIM is run without SSv2. For example in Nishinjuku scene, the pedestrian GameObjects are already present in the scene.

This of course can be resolved by having an additional script in the scene, which is given references to all pedestrian GameObjects and is responsible for registering them with RGL. Do you want us to implement such a solution?

[mackierx111]

I apologize for the late response.

no problem!

In any case, I don't think we should add code that depends on other classes. If such additions are made in the future, there will be more and more code to add caches other than RGL to each component class, such as NPCs, which we do not want.

For example, the following workarounds can be suggested

• Have NPC Pedestrian spawn at the start of Simulation. (And the spawning class will do the RGL cache)
• Refer to the first placed NPC Pedestrian and add it to the RGL cache.

[Goldob]

Understood, we will implement changes not to have references to RGL within pedestrian classes.

[ceccocats]

Nice work 👍
Unfortunately SceneManager: Update transforms and skinned meshes is still slow. It would be possible to just update objects that are not marked static in unity?