refactor: force ros2_timeout and agnocast_timeout to be equal #511
+16
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atsushi421 <[email protected]>
Koichi98
reviewed
Mar 12, 2025
| RCLCPP_ERROR( | ||
| logger, | ||
| "If `ros2_next_exec_timeout` is set to infinite, ros2 callbacks which share the callback " | ||
| "group " | ||
| "If `timeout` is set to infinite, ros2 callbacks which share the callback group " |
There was a problem hiding this comment.
正しく無いかもです。そして、実装変更した方が良い箇所を見つけたので、少々お待ちください。
There was a problem hiding this comment.
修正しました！8ebcaa2
実装変更は別でやります。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This forces
ros2_timeoutandagnocast_timeoutto be equal for fairness scheduling in MultiThreadedAgnocastExecutor.Related links
How was this PR tested?
bash scripts/e2e_test_1to1_with_ros2sub(required)bash scripts/e2e_test_2to2(required)Notes for reviewers