perf(srr520): remove mtqueue

[mojomex]

PR Type

• Improvement
• Bug fix

Related Links

• perf(hesai): remove decoder thread and MtQueue, make everything single-threaded #226 -- Hesai for reference
• test(nebula_ros): add smoke tests #240 -- smoke tests for reference

Description

Does what the title says.

Reasons for this change:

• The multithreaded queue is not needed (receive buffers in the network stack take care of arriving data while decoding).
• The decoder thread had no mechanism for gracefully stopping, thus causing an exception on exit
• The above excption caused our smoke tests to fail

Review Procedure

• Compare to the linked Hesai reference PR perf(hesai): remove decoder thread and MtQueue, make everything single-threaded #226
• Test with launch_hw:=false and a rosbag
• Test with launch_hw:=true and a real sensor or pcap

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.98%. Comparing base (33913f8) to head (734d62d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   30.94%   28.98%   -1.97%     
==========================================
  Files         112      113       +1     
  Lines        9688     9482     -206     
  Branches     4297     3092    -1205     
==========================================
- Hits         2998     2748     -250     
- Misses       6128     6255     +127     
+ Partials      562      479      -83     

Flag	Coverage Δ
differential	28.98% <33.33%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Common	18.48% <ø> (-31.77%)	⬇️
Hesai	29.69% <ø> (-0.72%)	⬇️
Velodyne	40.42% <ø> (+0.14%)	⬆️
Continental	30.83% <33.33%> (+2.84%)	⬆️
Robosense	0.00% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knzo25]

@mojomex
I do not think we have a real sensor to test this right now.
Would a bag suffice? Also, I do not think we are supporting this radar anymore 😅

[mojomex]

@knzo25 Yes, a bag would suffice.
The mechanism is the same for all vendors/devices, so in theory it should "just work" 🙌