Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ars548): implemented universal radar messages proposal #284

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Mar 3, 2025

PR Type

  • New Feature

Related Links

Related issue:
https://github.com/orgs/autowarefoundation/discussions/5264

Description

This PR provides a reference implementation for the universal radar messages explained in the previous link

The currently published PointCloud2 works as the universal radar detection implementation (we want the least number of restrictions over it so it can be expanded and can fully use each radars' features if needed, although autoware does not have a plan for this at the moment).

A new universal radar object message is used, which can model all of the radars we know of.

A new radar info message publishes information about each of the radar fields, such as if it is really filled, its ranges, and resolution.

Review Procedure

The new topics comply with the previous interface (I compared the original topics and the proposed ones with ros2 topic echo and confirmed that they worked as expected).

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@knzo25 knzo25 requested review from mojomex and drwnz March 3, 2025 04:58
@knzo25 knzo25 self-assigned this Mar 3, 2025
@knzo25 knzo25 added the enhancement New feature or request label Mar 3, 2025
@knzo25
Copy link
Collaborator Author

knzo25 commented Mar 3, 2025

CI/CD does not pass since the messages have not been merged into main yet (subject to review)
As such I will mark the PR as draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant