-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_system_msgs): add emergency holding msg #153
Conversation
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Are there any documentation about how this message is used? For example, I would like to know the following information:
|
@mitsudome-r |
@TetsuKawa Thanks.
If this is the case, it might be better to leave a comment at the beginning of message definition so that the users will know that this message will also be deprecated in the future. (Something like the follwing)
|
fixed in a89d58a |
Related Links
Purpose of the message
https://star4.slack.com/archives/C017VB9UG1L/p1729675438504999
↑Details of this chat
Currently, on X1, there is an issue where Autoware is in an Emergency state, but an Error notification is not displayed on the FMS. The condition for displaying an Error on the FMS is that the
emergency_holding
value within thehazard_status
topic is set to true.This issue is caused by the fact that when the configuration of
system_error_monitor and emergency_handler
was changed to the configuration ofdiagnostic_graph_aggregator, mrm_handler, and hazard_status_converter
(discussion), the implementation ofhazard_status_converter
was set so that theemergency_holding
value in the publishedhazard_status
topic is alwaysfalse
.The emergency_holding function, which previously existed in the
system_error_monitor
, has now been moved to themrm_handler
. Therefore, to update theemergency_holding
value in thehazard_status
topic published by thehazard_status_converter
, it is necessary to transmit the emergency_holding state from themrm_handler
. This is why the current PR is required to address the issue.Which node is meant to publish/subscribe the topic?
Pub: mrm_handler(PR)
Sub: hazard_status_converter(PR)
Does this message has to be in a separate message?
This message is temporary. In the future, both
hazard_status_converter and hazard_status
will be deprecated, andhazard_status
will no longer be used as an API. However, due to the aforementioned issue, a temporary topic addition will be made.Currently, there is a topic called
/system/operation_mode/availability
frommrm_handler
tohazard_status_converter
, but adding theemergency_holding
state to this topic would be inappropriate given its intended content. Since this is only a temporary value untilhazard_status_converter
is deprecated, the topic should be created independently.Description
This PR adds EmergencyHodingState msg.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks