CORE-11417: added localASNumber field to BGPPeer #2158
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for tigera failed. Why did it fail? →
|
mazdakn
reviewed
Jul 11, 2025
mazdakn
reviewed
Jul 11, 2025
Co-authored-by: Mazdak Nasab <[email protected]>
ctauchen
reviewed
Jul 15, 2025
| @@ -43,6 +43,7 @@ spec: | |||
| | node | If specified, the scope is node level, otherwise the scope is global. | The hostname of the node to which this peer applies. | string | | | |||
| | peerIP | The IP address of this peer and an optional port number. If port number is not set, and peer is Calico node with `listenPort` set, then `listenPort` is used. | Valid IPv4 or IPv6 address. If port number is set use, `IPv4:port` or `[IPv6]:port` format. | string | | | |||
| | asNumber | The remote AS Number of the peer. | A valid AS Number, may be specified in dotted notation. | integer/string | | |||
| | localASNumber | Specifies AS Number $[prodname] uses as its local AS Number for this peer, overriding the global AS Number set in the default BGPConfiguration. | A valid AS Number, may be specified in dotted notation. | integer/string | | |||
There was a problem hiding this comment.
Suggested change
| | localASNumber | Specifies AS Number $[prodname] uses as its local AS Number for this peer, overriding the global AS Number set in the default BGPConfiguration. | A valid AS Number, may be specified in dotted notation. | integer/string | | |
| | localASNumber | Specifies AS Number $[prodname] uses as its local AS Number for this peer, overriding the global AS Number set in the default BGPConfiguration. | A valid AS Number, may be specified in dotted notation. | integer/string | |
Same in repeated section below.
@ctauchen We are targeting it for |
Thanks. I'll hold this until I cut 3.22 ep1, then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Version(s):
OSS v3.31
Enterprise v3.22 EP2
Issue:
https://tigera.atlassian.net/browse/CORE-11417
Link to docs preview:
SME review:
DOCS review:
Additional information:
This PR introduces support for the optional localASNumber field within the BGPPeer resource in Calico. When specified, localASNumber sets the local ASN that Calico will use to establish the BGP session with the peer. This value overrides the default asNumber for that specific BGP peer only.
Key behavior:
If localASNumber is set, it takes precedence over the asNumber field for the local ASN used in the BGP session.
If localASNumber is omitted, the default asNumber is used.
This field is supported for both global and node-specific peers.
Use case:
Merge checklist: