-
Notifications
You must be signed in to change notification settings - Fork 129
[CORE-11642] Add note about enabled ANNOTATE_POD_IP setting to EKS guide. #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview succeeded!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -38,6 +38,7 @@ When using the Amazon VPC CNI plugin, $[prodname] does not support enforcement o | |||
***Prerequisites*** | |||
|
|||
* You [disabled network policy for the AWS VPC CNI](https://docs.aws.amazon.com/eks/latest/userguide/network-policy-disable.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually, how can this be a pre-req when you've not created your cluster yet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this recently and have draft changes in the works. It also seems that network policy is disabled by default, so it may be altogether unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shuffled it around; any better (or do you want to take it over as part of your rework?)
@@ -38,6 +38,7 @@ When using the Amazon VPC CNI plugin, $[prodname] does not support enforcement o | |||
***Prerequisites*** | |||
|
|||
* You [disabled network policy for the AWS VPC CNI](https://docs.aws.amazon.com/eks/latest/userguide/network-policy-disable.html). | |||
* You [configured AWS VPC CNI to annotate Pods with their IPs](https://github.com/aws/amazon-vpc-cni-k8s?tab=readme-ov-file#annotate_pod_ip-v193). Note the requirement to grant the "patch" permission to the `aws-node` daemon set. Without this setting, pod IPs can propagate slowly when Kubernetes is under load resulting in slow policy application after pod creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we must encounter the same problem here as with the other prerequisite. Is this something that needs to come after the cluster is created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they're both settings you must make when configuring AWS CNI. I think the policy one can be done at cluster creation time by passing an option to eksctl
Product Version(s):
All
Issue:
https://tigera.atlassian.net/browse/CORE-11642
Link to docs preview:
https://deploy-preview-2174--calico-docs-preview-next.netlify.app/calico/next/getting-started/kubernetes/managed-public-cloud/eks/
SME review:
DOCS review:
Additional information:
Merge checklist: