DOC-2684 feat(loading): new kafka data source; #807
Merged
+527
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchantg
approved these changes
Apr 21, 2025
romansod
reviewed
Apr 21, 2025
modules/data-loading/partials/kafka-mm/kafka-filename-details.adoc
Outdated
Show resolved
Hide resolved
victorleeTG
approved these changes
May 2, 2025
Comment on lines
-41
to
-44
| == Kafka Loader Auto-Restart | ||
|
|
||
| See xref:tigergraph-server:cluster-and-ha-management:ha-overview.adoc#_support_file_and_kafka_loader_by_auto_restart[High Availability (HA) Overview]. | ||
|
|
There was a problem hiding this comment.
@pingxieTG Why do you propose to remove this?
Does the loader HA working differently? Do the parameters mentioned in that section
(https://docs.tigergraph.com/tigergraph-server/4.1/cluster-and-ha-management/ha-overview#_file_and_kafka_loaders_ha_with_auto_restart) no longer apply?
modules/data-loading/partials/kafka/kafka-data-source-details.adoc
Outdated
Show resolved
Hide resolved
modules/data-loading/partials/kafka/kafka-data-source-details.adoc
Outdated
Show resolved
Hide resolved
modules/data-loading/partials/kafka/kafka-filename-details.adoc
Outdated
Show resolved
Hide resolved
modules/data-loading/partials/kafka/kafka-filename-details.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Lee <[email protected]>
…adoc Co-authored-by: Victor Lee <[email protected]>
…adoc Co-authored-by: Victor Lee <[email protected]>
Co-authored-by: Victor Lee <[email protected]>
Co-authored-by: Victor Lee <[email protected]>
victorleeTG
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka-mm, as well as its "partials". Mark this approach "Deprecated"