DOC-2921 support sampling local file [4.3] #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorleeTG
requested changes
Oct 1, 2025
| === Get the sample data of local files | ||
| `POST /gsql/v1/sample-data` | ||
|
|
||
| Get the sample data of local files |
There was a problem hiding this comment.
Suggested change
| Get the sample data of local files | |
| Get the first N of lines of data from a local file, as a sample |
"Sample" is a generic, non-specific concept. To a statistician, "sample" actually suggests that the data is chosen randomly. But I assume our selection is not random. We are selecting the first N lines. Is that correct?
We should provide a clearly explanation of how the data is chosen.
| ---- | ||
| -- | ||
| ==== | ||
| === Get the sample data of local files |
There was a problem hiding this comment.
Suggested change
| === Get the sample data of local files | |
| === Get sample data from a local file |
"The" is incorrect, because there is not just one possible or correct sample of data.
The data is coming from only one file, not "files"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.