Allow outputting URLs with trailing slash #692
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures the order of files is deterministic
gcavanunez
force-pushed
the
trailing-slash
branch
from
6ca55d6 to
9f8ba71
Compare
....✓...................✓........✓.............✓....✓..........✓✓......✓..✓. ......✓✓✓✓✓.✓..✓....✓✓....✓............ ──────────────────────────────────────────────────────────────────── Laravel FIXED ................................. 115 files, 19 style issues fixed ✓ src/Collection/Collection.php new_with_parentheses, unary_operator_spaces… ✓ src/Console/BuildCommand.php new_with_parentheses, unary_operator_spaces,… ✓ src/Events/EventBus.php new_with_parentheses ✓ src/Exceptions/Handler.php nullable_type_declaration_for_default_null_val… ✓ src/File/TemporaryFilesystem.php new_with_parentheses ✓ src/Scaffold/PresetPackage.php new_with_parentheses, unary_operator_space… ✓ src/SiteData.php new_with_parentheses ✓ src/Support/helpers.php new_with_parentheses, unary_operator_spaces, not_… ✓ tests/CustomCommandTest.php new_with_parentheses ✓ tests/CustomScaffoldInstallerTest.php new_with_parentheses ✓ tests/DefaultScaffoldInstallerTest.php new_with_parentheses ✓ tests/DotInFileNameTest.php new_with_parentheses ✓ tests/FilePathTest.php new_with_parentheses ✓ tests/InitCommandTest.php new_with_parentheses ✓ tests/PhpOpenTagInMarkdownTest.php new_with_parentheses ✓ tests/PresetScaffoldBuilderTest.php new_with_parentheses ✓ tests/SnapshotsTest.php new_with_parentheses, php_unit_method_casing, una… ✓ tests/TestCase.php new_with_parentheses, class_definition, braces_positio… ✓ tests/snapshots/default-trailing-slash/config.php list_syntax )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
trailing_slashconfig option that makes->getUrl()always output a URL with a trailing slash. Doesn't affect->getPath()or anything else.Fixes #679 I think?