Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type definition for route() with only options #786

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

bram-pkg
Copy link
Contributor

@bram-pkg bram-pkg commented Nov 6, 2024

The order of function definitions was disallowing route(undefined, undefined, undefined, config) to be matched. This PR fixes that.

I've also added a test to ensure this doesn't fail again in the future.

@bakerkretzmar
Copy link
Collaborator

Thanks! I could have sworn I put them in the previous order specifically to avoid an issue like this where one of the definitions wasn't getting matched, but clearly your fix here works.

@bakerkretzmar bakerkretzmar merged commit d379ade into tighten:2.x Nov 9, 2024
22 checks passed
@bram-pkg
Copy link
Contributor Author

bram-pkg commented Nov 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants