Honor absolute paths passed to ziggy:generate - #891
Open
lazerg wants to merge 1 commit into
Open
Conversation
lazerg
force-pushed
the
fix/issue-882-absolute-path
branch
from
July 1, 2026 17:28
64958c8 to
531720d
Compare
lazerg
force-pushed
the
fix/issue-882-absolute-path
branch
from
July 1, 2026 17:34
531720d to
1231a81
Compare
Collaborator
|
I think this is the right move but it's definitely a breaking change so it'll have to go into the next major release. Will try to get it merged sooner than later though and start planning for that. Thanks! |
Contributor
Author
|
Hey @bakerkretzmar, mind taking a look at this one when you get a chance 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ziggy:generatewraps the output path inbase_path()unconditionally, so passing an absolute path like/tmp/ziggy.jswrites the file under the application root instead of where it was requested. This routes every path through a small helper that only prependsbase_path()when the path is relative, leaving absolute paths untouched.Closes #882.