Refresh profile guidance and localized documentation links - #108
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Checks
rush changeandrush change --verifyagainstupstream/main; the private website requires no release changefile.Summary
Refresh English and Chinese website guidance: remove the obsolete "not implemented" label from the supported
--no-profilecommand, fix the GitK command-reference URL/name, keep the Chinese homepage's feature links in Chinese, and let the Chinese footer inherit the configured current-year copyright string.The root README links have a separate feedback history and are tracked in #107.
How to test it
rush rebuild --to website --productionunder Node 18.20.8, matching the CI major: passed, both locales generated.--no-profileno longer says unimplemented, GitK links use the working official URL, the two Chinese feature links resolve under/sparo/zh-cn/, and both footers use the configured current year.rush prettier,rush change --verify --no-fetch --target-branch upstream/main, andgit diff --checkpassed.An earlier Node 24 build generated both locales but returned nonzero because of dependency deprecation warnings; the Node 18 build above completed successfully. No dependencies or CLI behavior changed.