Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-fn-result-suspend-on-waiting.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect-atom/atom": patch
---

pass suspendOnWaiting options to resultOnce in Atom.fn context
2 changes: 1 addition & 1 deletion packages/atom/src/internal/registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ const LifetimeProto: Omit<Lifetime<any>, "node" | "finalizers" | "disposed" | "i
if (this.disposed) {
throw disposedError(this.node.atom)
} else if (this.isFn) {
return this.resultOnce(atom)
return this.resultOnce(atom, options)
}
const result = this.get(atom)
if (options?.suspendOnWaiting && result.waiting) {
Expand Down
51 changes: 51 additions & 0 deletions packages/atom/test/Atom.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1422,6 +1422,57 @@ describe("Atom", () => {

unmount2()
})

it("get.result suspendOnWaiting", async () => {
const r = Registry.make()

const inner = Atom.make(Effect.succeed(1).pipe(Effect.delay(50)))
const outer = Atom.make((get) => get.result(inner, { suspendOnWaiting: true }))

r.mount(outer)

let result = r.get(outer)
assert(result.waiting)

await vitest.advanceTimersByTimeAsync(50)

result = r.get(outer)
assert(Result.isSuccess(result))
assert.strictEqual(result.value, 1)
})

it("fn get.result suspendOnWaiting", async () => {
const r = Registry.make()
let runs = 0

const inner = Atom.fn((n: number) => {
runs++
return Effect.succeed(n * 2).pipe(Effect.delay(50))
})

const outer = Atom.fn(
Effect.fn(function*(_: void, get: Atom.FnContext) {
get.set(inner, 1)
const a = yield* get.result(inner, { suspendOnWaiting: true })

get.set(inner, 2)
const b = yield* get.result(inner, { suspendOnWaiting: true })

return { a, b }
})
)

r.mount(outer)
r.set(outer, void 0)

await vitest.advanceTimersByTimeAsync(100)

const result = r.get(outer)
assert(Result.isSuccess(result))
assert.strictEqual(result.value.a, 2)
assert.strictEqual(result.value.b, 4)
assert.strictEqual(runs, 2)
})
})

interface BuildCounter {
Expand Down