Skip to content

Fix for https://github.com/timaschew/link-checker/issues/34 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for https://github.com/timaschew/link-checker/issues/34 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd7d2dd
Fix for https://github.com/timaschew/link-checker/issues/34
dweiss Apr 26, 2023
97a07c2
Use path.join to make the test os-independent.
dweiss Sep 21, 2023
525a4d2
Update superagent, regenerate the lock file, removed node constraint.
dweiss Sep 21, 2023
2b720d3
Add a test for handling http status ignoring (403).
dweiss Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions link-checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,15 @@ module.exports = function(directory, options = {}, callback) {
: typeof target === "object" ? target.request.url // superagent response
: typeof target === "string" ? target // plain URL
: null

const matchingPattern = Array.from(options.overrides.keys()).find(
pattern => pattern.exec(url)
)

if(!matchingPattern) return options

return {...options, ...options.overrides.get(matchingPattern)}

const opts = {...options, ...options.overrides.get(matchingPattern)}
return opts
}

walker(directory, function(filePath, fileContent) {
Expand Down Expand Up @@ -182,13 +184,16 @@ module.exports = function(directory, options = {}, callback) {

// decode anchors
const splitted = href.split('#')
var resolvedHref
if (splitted.length == 2) {
const url = splitted[0]
const anchor = splitted[1]
href = url + '#' + urlencode.decode(anchor)
resolvedHref = path.join(path.dirname(filePath), url) + '#' + urlencode.decode(anchor)
} else {
resolvedHref = path.join(path.dirname(filePath), href)
}

const resolvedHref = path.join(path.dirname(filePath), href)
debug('text content for ' + resolvedHref, $this.html())
if (href.indexOf('http://') == 0 || href.indexOf('https://') == 0) {
if (href.indexOf('#') == -1) {
Expand Down
Loading