Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get timestamp from snapshot function #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Raufabdul8
Copy link

This pull request resolves issue #3 by making a common function for getting timestamp from snapshot filename.

@timea-solid
Copy link
Owner

Hi @Raufabdul8. Thank you for your PR, it is a really needed cleaning of the code!
However it does not solve issue3. I think my description of the problem was not clear.
Now the '.ttl' file type is hardcoded -> this is the problem. It should read the file type from the name of the file and reuse it.
What you refactored is a much appreciated preliminary step.

@Raufabdul8
Copy link
Author

Added a simple fix to handle most file extensions.

@timea-solid
Copy link
Owner

timea-solid commented Jul 21, 2022

@Raufabdul8 brilliant!
Now last step (we are very close) ->

let docName = nameOfSnapshot + "-" + timestamp + ".ttl"

nameOfSnapshot now comes from a config but it should be the same name and file type like the one we make a snapshot of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants