feat: add docs about potential python integration #208
+1,060
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askir
commented
Nov 12, 2024
Comment on lines
+42
to
+50
| def __get__(self, obj, objtype=None): | ||
| """ | ||
| When accessed on class (BlogPost.content_embeddings) -> return Embedding class | ||
| When accessed on instance (post.content_embeddings) -> return relationship data | ||
| """ | ||
| if obj is None: # Class access | ||
| return self._embedding_class | ||
| # Instance access - return relationship data through the relationship property | ||
| return getattr(obj, f"_{self.name}_relation") |
There was a problem hiding this comment.
This is a bit of a nasty hack.
I wanted to enable querying all Embeddings under the same key as you'd retrieve the subobjects if you already have a BlogPost.
This is not default sqlalchemy behaviour (because you'd usually have the embedding class defined separately). Alternatively I can just defined a property Embeddings on the parent model, that might end up working out better.
Or we disabled the relationship mapping by default then this attribute free to be used by the Embedding model I suppose?
Will think about it a bit more, happy about additional input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: My experiments on python tooling integrations.
Note a bunch of this is claude code and quite hacky still. Just iterating fast to see what's possible from the SQLAlchemy/Alembic side.