some experiments with vectorized expressions #8595
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some places did not handle the uuids which led to internal program errors.
The dashes can sort differently based on collation, so the test can fail depending on the locale. Remove the dashes to fix.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8595 +/- ##
==========================================
- Coverage 82.42% 80.52% -1.91%
==========================================
Files 244 244
Lines 47953 46823 -1130
Branches 12235 12158 -77
==========================================
- Hits 39525 37702 -1823
- Misses 3553 4299 +746
+ Partials 4875 4822 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If a grouping or aggregation expression contains a Postgres function like time_bucket(), evaluate it on the columnar arguments and store the result in the columnar format, so that rest of the query can continue using the columnar pipeline. In particular, this allows us to use vectorized aggregation with grouping by time_bucket().
No functional changes for now. We'll have to use it in aggregate evaluation separately, to avoid multiple evaluation of aggregate arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts: