Skip to content

Remove column dropped from _timescaledb_catalog.chunk #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
svenklemm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove column dropped from _timescaledb_catalog.chunk #9142

svenklemm wants to merge 1 commit into from

Conversation

@svenklemm
Copy link
Member

@svenklemm svenklemm commented Jan 18, 2026

With the removal of support for old format caggs we can remove
support for chunks to be marked as dropped instead of always dropping
from our catalog. This commit removes the code dealing with this
variant and removes the dropped flag from our catalog.

@svenklemm svenklemm requested a review from a team January 18, 2026 19:31
@github-actions github-actions bot requested a review from melihmutlu January 18, 2026 19:31
@github-actions
Copy link

github-actions bot commented Jan 18, 2026

@pnthao, @melihmutlu: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested a review from pnthao January 18, 2026 19:31
@codecov
Copy link

codecov bot commented Jan 19, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.70%. Comparing base (1bbb034) to head (9d5b4d3).

Files with missing lines Patch % Lines
src/chunk.c 84.48% 2 Missing and 7 partials ⚠️
src/process_utility.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9142      +/-   ##
==========================================
+ Coverage   82.46%   82.70%   +0.24%     
==========================================
  Files         244      244              
  Lines       47875    47754     -121     
  Branches    12207    12167      -40     
==========================================
+ Hits        39478    39496      +18     
+ Misses       3564     3516      -48     
+ Partials     4833     4742      -91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svenklemm svenklemm added the tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. label Jan 19, 2026
@dbeck
Copy link
Member

dbeck commented Jan 19, 2026

Why did we have the dropped flag at the first place?

@svenklemm
Copy link
Member Author

svenklemm commented Jan 19, 2026

Why did we have the dropped flag at the first place?

Old format continuous aggregates had references to the chunk they originated from so when we needed to drop chunks on hypertables with caggs we instead marked them as dropped

@svenklemm
Remove column dropped from _timescaledb_catalog.chunk
9d5b4d3 
With the removal of support for old format caggs we can remove
support for chunks to be marked as dropped instead of always dropping
from our catalog. This commit removes the code dealing with this
variant and removes the `dropped` flag from our catalog.
gayyappan
gayyappan reviewed Jan 19, 2026
View reviewed changes
Copy link
Member

@gayyappan gayyappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you hold off on merging this change? There is a potential usecase for this.

@fabriziomello
Copy link
Member

fabriziomello commented Jan 19, 2026

Could you hold off on merging this change? There is a potential usecase for this.

what use case? the only use case we had was the old caggs format that was completely removed from our code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gayyappan gayyappan gayyappan left review comments

@fabriziomello fabriziomello fabriziomello approved these changes

@antekresic antekresic antekresic approved these changes

@melihmutlu melihmutlu Awaiting requested review from melihmutlu

@pnthao pnthao Awaiting requested review from pnthao

@akuzm akuzm Awaiting requested review from akuzm

Assignees

@svenklemm svenklemm

Labels

tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@svenklemm @dbeck @fabriziomello @antekresic @gayyappan