Switch to unversioned clang in regression tests

[akuzm]

At the moment we require version 14 which is pretty old. Just like we do with gcc, do not pin a particular version. This risks sudden changes when the distribution updates their default version, but it should be infrequent. The problem with pinning a version is that we now use Ubuntu 22.04 on self-hosted runners, so we can't pin it to anything new because these packages are not accessible there.

[erimatnor]

Thank you, I was about to fix this because it has been annoying. :)

[erimatnor]

There should also be formatting changes, right? At least that is what I get on never clang-formats.

[akuzm]

There should also be formatting changes, right? At least that is what I get on never clang-formats.

I'm not touching clang-format here though. We need to pick up some occasion when there are not a lot of in-flight PRs to avoid conflicts, maybe just after 2.25 freeze.

This one will require clang-tidy changes but there are not a lot.

[akuzm]

Oh, we're also on ubuntu 22.04, this is going to take some time...

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (2fbac8b) to head (399977f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9149      +/-   ##
==========================================
+ Coverage   82.48%   82.64%   +0.16%     
==========================================
  Files         244      244              
  Lines       47893    47893              
  Branches    12208    12208              
==========================================
+ Hits        39504    39583      +79     
- Misses       3560     3562       +2     
+ Partials     4829     4748      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[svenklemm]

Certain llvm versions are troublesome are we sure we want to unpin llvm too

[akuzm]

Certain llvm versions are troublesome are we sure we want to unpin llvm too

It seems to work, so I would experiment with it and see how it goes. I ran into problems with the old Postgres not supporting a new LLVM version, but the distribution defaults are reasonably conservative, so this part should be OK.

The comment in the gh_matrix_builder says that the clang and the llvm version must match, so not sure we can unpin one and not another.

[akuzm]

Merging after 2.25 release to avoid destabilizing the things.