Skip to content

allow setting the channel offset #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow setting the channel offset #12

wants to merge 1 commit into from

Conversation

dhiltonp
Copy link

@dhiltonp dhiltonp commented Feb 8, 2024

This is the easiest way of allowing a client to set the channel offset.

@dhiltonp dhiltonp mentioned this pull request Feb 8, 2024
Open
@dhiltonp
Copy link
Author

dhiltonp commented Feb 8, 2024 •
edited
Loading

Would you prefer to not have this additional argument, and clients directly call self.enabled_channels.write().insert(channel, channel_config);?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhiltonp