Migration tenders-finder to Tinyfish SDK - #206
KrishnaAgarwal7531 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
simantak-dabhade
left a comment
There was a problem hiding this comment.
Review: changes requested
SDK migration is correct — client.agent.stream() with proper EventType/RunStatus handling, no raw fetch, no Mino, no leaked secrets. Good work there.
Build is broken due to unused shadcn/ui components importing missing Radix packages.
Blockers
1. Delete 11 unused shadcn/ui component files + use-toast.ts
npm run build fails because label.tsx imports @radix-ui/react-label which isn't in package.json. None of these 11 files are imported anywhere in the app — they're all dead code:
src/components/ui/button.tsxsrc/components/ui/dialog.tsxsrc/components/ui/input.tsxsrc/components/ui/label.tsx← breaks the buildsrc/components/ui/separator.tsxsrc/components/ui/sheet.tsxsrc/components/ui/skeleton.tsxsrc/components/ui/toast.tsxsrc/components/ui/toaster.tsxsrc/components/ui/toggle.tsxsrc/components/ui/tooltip.tsxsrc/components/ui/use-toast.ts
Delete all of them. The app renders fine without them.
2. Remove next-env.d.ts
This is auto-generated by Next.js and should not be committed. Delete it and add next-env.d.ts to .gitignore.
Non-blocking
- Add
.envto.gitignore(currently only.env.localis covered) - Remove unused
@radix-ui/react-scroll-areafrompackage.json
Once the build passes (npm install && npm run build), this is good to merge.
Migrates Tenders Finder to the official TinyFish SDK. /api/scrape uses client.agent.stream with typed EventType.STARTED, EventType.STREAMING_URL, EventType.PROGRESS, and EventType.COMPLETE + RunStatus.COMPLETED. No Mino refs, no Supabase, .env.example present.
Added .gitignore and README.md.