Skip to content

Migration tenders-finder to Tinyfish SDK - #206

Closed
KrishnaAgarwal7531 wants to merge 1 commit into
tinyfish-io:mainfrom
KrishnaAgarwal7531:tenders
Closed

KrishnaAgarwal7531 wants to merge 1 commit into
tinyfish-io:mainfrom
KrishnaAgarwal7531:tenders

Conversation

@KrishnaAgarwal7531

Copy link
Copy Markdown
Contributor

Migrates Tenders Finder to the official TinyFish SDK. /api/scrape uses client.agent.stream with typed EventType.STARTED, EventType.STREAMING_URL, EventType.PROGRESS, and EventType.COMPLETE + RunStatus.COMPLETED. No Mino refs, no Supabase, .env.example present.
Added .gitignore and README.md.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a11eb952-44d1-4168-9d97-050ea2cc7212

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@simantak-dabhade simantak-dabhade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: changes requested

SDK migration is correct — client.agent.stream() with proper EventType/RunStatus handling, no raw fetch, no Mino, no leaked secrets. Good work there.

Build is broken due to unused shadcn/ui components importing missing Radix packages.

Blockers

1. Delete 11 unused shadcn/ui component files + use-toast.ts

npm run build fails because label.tsx imports @radix-ui/react-label which isn't in package.json. None of these 11 files are imported anywhere in the app — they're all dead code:

  • src/components/ui/button.tsx
  • src/components/ui/dialog.tsx
  • src/components/ui/input.tsx
  • src/components/ui/label.tsx ← breaks the build
  • src/components/ui/separator.tsx
  • src/components/ui/sheet.tsx
  • src/components/ui/skeleton.tsx
  • src/components/ui/toast.tsx
  • src/components/ui/toaster.tsx
  • src/components/ui/toggle.tsx
  • src/components/ui/tooltip.tsx
  • src/components/ui/use-toast.ts

Delete all of them. The app renders fine without them.

2. Remove next-env.d.ts

This is auto-generated by Next.js and should not be committed. Delete it and add next-env.d.ts to .gitignore.

Non-blocking

  1. Add .env to .gitignore (currently only .env.local is covered)
  2. Remove unused @radix-ui/react-scroll-area from package.json

Once the build passes (npm install && npm run build), this is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants