Skip to content

Migration wing-command to Tinyfish SDK - #210

Closed
KrishnaAgarwal7531 wants to merge 1 commit into
tinyfish-io:mainfrom
KrishnaAgarwal7531:main
Closed

KrishnaAgarwal7531 wants to merge 1 commit into
tinyfish-io:mainfrom
KrishnaAgarwal7531:main

Conversation

@KrishnaAgarwal7531

Copy link
Copy Markdown
Contributor

Migrates Wing Command from raw TinyFish HTTP calls to the official SDK, and tears out the Supabase + Redis infrastructure that was never needed for this use case. The app now runs entirely in-memory — no database to provision, no cache to configure, just two API keys and you're running.
The app itself finds the best chicken wing spots near you by zip code. Pick a flavor persona, and it fires parallel browser agents at DoorDash, Uber Eats, Grubhub, and Google simultaneously, streaming results back as each source finishes rather than waiting for all of them.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f2bf03d7-2e6f-4086-a277-b34d7977dd69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@simantak-dabhade simantak-dabhade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: changes requested

The core SDK migration in /api/scout/route.ts is correct — client.agent.stream() with proper EventType/RunStatus, Gemini for URL discovery, no raw fetch, no Mino, no secrets. The architecture is sound.

However, the build fails with 129 TypeScript errors and there's significant dead code that needs cleanup.

Blockers

1. Build fails — 129 TypeScript errors

The WingSpot type in lib/types.ts was slimmed down during migration, but many components and lib/utils.ts still reference old properties that no longer exist:

  • price_per_wing, delivery_time_mins, deal_text, platform_ids, is_in_stock, is_open_now, flavor_tags, menu_json, opens_during_game, wait_time_mins, etc.

Affected files: ScoutingReportCard, CompareModal, WingGrid, DealsView, MenuModal, FlavorSelector, lib/utils.ts

Also:

  • AvailabilityStats missing percentage: number (used in CommandJumbotron.tsx:218)
  • FlavorPersonaInfo missing id, subtitle, keywords (used in utils.ts)

Fix: either restore the removed properties in types.ts or update all components to use the new property names. Given the scale, I'd recommend restoring the type properties and then deleting the components that are truly unused (see #2).

2. Delete 11 unused component files

These are never imported by any page:

  • AnimatedFieldBackground, BannerBreak, ComicHero, FlavorSelector, FrostedGlassPanel, HeroVisuals, JumbotronSearch, SunnyFieldEntrance, TacticalCanvas, WingGrid, ZipSearch

Additionally DealsView and MenuModal reference deleted API routes (/api/deals, /api/menu) and deleted types — they will crash if ever imported.

3. Delete unused /api/discover/route.ts

This route is never called. Discovery is inlined in /api/scout.

4. Remove 4 unused npm dependencies

  • @tanstack/react-query (never imported)
  • date-fns (never imported)
  • canvas-confetti (never imported)
  • zod (never imported)

5. Remove next-env.d.ts

Auto-generated, should not be committed. Add to .gitignore.

Non-blocking

  1. README architecture shows /api/discover as separate step but it's inlined in /api/scout.
  2. lib/utils.ts header says "Wing Scout v3" — should be v4.

This PR needs a significant cleanup pass. The SDK migration itself is done right, but the surrounding code wasn't updated to match the new types. Please fix the type errors, remove dead code, and verify npm run build passes before re-requesting review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants