Skip to content

Conversation

@brnrd
Copy link

@brnrd brnrd commented Jun 11, 2013

With this slight change, a Node.js server that imports the module still works with Windows but now works too with Linux.

The hosts object contains a _store that's an object containing itself a _store. The access to the second one was missing.

{ _zone: '.',
_store:
{ _store: { _store: [Object] }, <----
_zone: '.',
_max_keys: undefined,
_ttl: { length: 0, root: undefined, _comparator: [Function] } },
purge: [Function] }

It would solve the issue #51 and it would be great to push it to NPM as well.

Thanks.

@taoeffect
Copy link
Collaborator

This project is no longer maintained, but we are happy to link to a well maintained fork.

Please see: #111

@jameshartig
Copy link

@brnrd I'm looking and noticing that the _store object is an instance of MemoryStoreExpire which does have a _store on it, but it also has a set method so the existing code should be working fine. Can you provide a test case I can run easily to try and debug this?

@brnrd
Copy link
Author

brnrd commented Feb 18, 2016

@fastest963 @taoeffect Since this was posted almost 3 years ago, I'm not sure this is still an issue.
I haven't pursued the project where I was using node-dns, therefore I don't really need it anymore.

And sadly, I don't have the time now to debug it. This PR could be closed if that's ok with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants