-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add completion command #442
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
- Replace hardcoded paths with `os.homedir()` and `path.join()` - Ensure tests run consistently across different operating systems
…consistency Co-authored-by: spageektti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small consideration on README.
The code itself LGTM. I will run a couple of tests on this branch just to be sure, and comment here as soon as it is all checked.
Thanks for the contribution, @Zamoca42 ! 🥇
It works like a charm, @Zamoca42 ! Thanks a lot! 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution. If possible, can you revert the oh my zsh plugin section beside the new zsh
docs (the zplug
one isn't required) since it allows using the commands with shortcuts?
@kbdharun I have reverted the oh-my-zsh plugin section in README! |
Description
I've implemented the auto-completion feature suggested in roadmap issue #342.
A new
completion.js
file was created to generate and install auto-completion scripts for both bash and zsh shells. I've also added acompletion
command tobin/tldr
.Images showing the feature in action are attached.
Details
completion.js
to handle completion script generation and installationbin/tldr
to include a newcompletion
commandI hope this feature makes using tldr even more convenient.
zsh
bash
Checklist
Please review this checklist before submitting a pull request.
npm run test:all
)Related
Closes #342