-
-
Notifications
You must be signed in to change notification settings - Fork 5k
scripts: Explicitly exclude pages.en, add PowerShell test script version #20575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The build for this PR failed with the following error(s) at commit Please fix the error(s) and push again. |
|
|
||
| # Check which PowerShell version available, prefers `pwsh` over `powershell`. | ||
| if (Exists("pwsh")) { | ||
| $msgs = pwsh "scripts\check-pr.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing right?
maybe better to split this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing right?
maybe better to split this PR?
@sebastiaanspeck It seems the original scripts/check-pr.sh contains regex patterns to check for outdated pages, missing command examples, etc. And there will be differences between the Unix-style and the PowerShell/.NET-style regex patterns.
Since check-pr.sh is meant to be primarily used for GitHub Actions, do you think we need to have a working PowerShell version at this point? I'd prefer to remove CI-related code on the PowerShell script.
Checklist
common,linux,osx,windows,sunos,android, etc.I'm making significant changes to the test scripts to support Windows development environments by rewriting
scripts/test.shinto PowerShell, then modify thenpm testcommand (as used in Git pre-commit hooks) to check the host operating system before loading the correct Bash/PowerShell file.This is because
bashin Windows 10 and Windows 11 users would trigger the WSL environment instead ofbashin Cygwin, Git Bash, or Msys2, and will break if necessary Node.js and Python tools are not present in both Windows and WSL.In addition to that,
pages.enis explicitly excluded in the Bash script (similar to #18653) because Git would most likely not to resolve symbolic links in Windows (and hence WSL while accessing Windows directories) for technical reasons (https://gitforwindows.org/symbolic-links.html).pages.enis treated as a normal file in the existing Bash script, and will trigger TLDR107 errors for the specific file.Note: