Skip to content

Fix missing properties in JSON output #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing properties in JSON output #137

wants to merge 1 commit into from

Conversation

@ic0ns
Copy link
Contributor

@ic0ns ic0ns commented Jun 27, 2025

Summary

  • Added getter methods to expose SUPPORTS_OCSP_STAPLING and TLS13 session ticket properties in JSON output
  • These properties were already being collected but were not visible in the JSON serialization

Changes

  • Added getSupportsOcspStapling() method to ServerReport
  • Added getIssuesTls13SessionTicketsAfterHandshake() method to ServerReport
  • Added getIssuesTls13SessionTicketsWithApplicationData() method to ServerReport
  • Added test to verify the properties are correctly serialized to JSON

Test plan

  • Added unit test testSerializeOcspAndSessionTicketProperties to verify JSON serialization
  • Test passes successfully
  • Code compiles without errors
  • Spotless formatting applied

Fixes #109

Add missing properties to JSON output
d9e7be1 
- Add SUPPORTS_OCSP_STAPLING to JSON output
- Add ISSUES_TLS13_SESSION_TICKETS_AFTER_HANDSHAKE to JSON output
- Add ISSUES_TLS13_SESSION_TICKETS_WITH_APPLICATION_DATA to JSON output
- Add test to verify properties are correctly serialized

Fixes #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SUPPORTS_OCSP_STAPLING and SUPPORTS_TLS13_SESSION_TICKETS missing from JSON output

1 participant

@ic0ns