fix(harness): bind websocket relay to proto_proxy IP#1091
Merged
themighty1 merged 8 commits intomainfrom Mar 3, 2026
Merged
Conversation
sinui0
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the harness (browser targets) where the verifier latency was not applied.
The cause:
when the relay connected to the verifier, it used the default source IP (the bridge at 10.250.0.1). The verifier's response traffic to 10.250.0.1 used the default route via
veth_rpc, which has no delay configured.The fix:
configure the relay to bind to the proto_proxy IP (10.250.0.2) before connecting to the verifier. This ensures the verifier sees the connection coming from 10.250.0.2 and responds to that address, which routes through
veth_protowith proper delay emulation.Depends on tlsnotary/tlsn-utils#98
I also added a temporary test plugin which can be run with
./bin/runner --target browser test --name rttIt fails before the fix and passes after the fix.
I will remove the temporary plugin before merging this PR and will change the base to
dev(currently the browser harness is broken on dev).