Tiny structural improvement of README. #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example for `mode: :object` in the very top.
tenderlove
requested changes
Jul 6, 2023
| StackProf.run(mode: :object, out: "tmp/stackprof-cpu-myapp.dump") do | ||
| #... | ||
| end | ||
| ``` |
There was a problem hiding this comment.
I don't think this is accurate. You should only switch from :cpu to :object when you want to change from profiling time to profiling object allocations. If you run with :cpu doesn't produce any samples it means that your sampling frequency might not be high enough. Measuring :cpu vs :object are completely different things (some code could take lots of time but allocate no objects, some code could run fast but allocate many objects).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some headers an example for
mode: :objectin the very top.Thanks for this tool, I am in love with it! 💚