Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

behavioral/chain_of_responsibility: implemented chain of responsibility pattern #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

behavioral/chain_of_responsibility: implemented chain of responsibility pattern #72

wants to merge 2 commits into from

Conversation

epsilon-akshay
Copy link

Chain of responsibility pattern was implemented for a number processor which returns if the given value is negative, positive or zero.

jbactad
jbactad reviewed Mar 12, 2019
View reviewed changes
Copy link

@jbactad jbactad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, its better if the process method can accept a Request object. I think it will give flexibility to the processors to accept a float for example.

@epsilon-akshay
Copy link
Author

will do that. 👍

@epsilon-akshay
Copy link
Author

do check the new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbactad jbactad jbactad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epsilon-akshay @jbactad