Migrate to Python 3; bug fix #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the example and core code to Python 3. Fixed issue where tables with multiple column dimensions would not display correctly; column header generation code was adjusting rowspan rather than colspan.
Updated project priorities.
Dimtable now attempts to sort items in each dimension numerically, then lexically. Updated html.py to python 3. Added new KeyedTable class, designed to work with a data-set that takes keyed input. Moved dimtable.css to static folder, so that it can be used with staticfiles. Cleaned up imports. Added new virtual_table class, which does not generate html on its own, and is intended to be used in conjunction with the new multi_table template tag. Eventually, this will completely replace the old dim_table class. Added default templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the example and core code to Python 3.
Fixed issue where tables with multiple column dimensions would not
display correctly; column header generation code was adjusting rowspan
rather than colspan.
Fixed settings import in example manage.py to use django.conf.settings