fix(embed): truncate oversized chunks to prevent context window crash#316
Open
debugerman wants to merge 1 commit intotobi:mainfrom
Open
fix(embed): truncate oversized chunks to prevent context window crash#316debugerman wants to merge 1 commit intotobi:mainfrom
debugerman wants to merge 1 commit intotobi:mainfrom
Conversation
The embedding model (embeddinggemma-300M) has a 2048-token context window. Chunks exceeding this limit cause node-llama-cpp to crash with SIGABRT on Apple Silicon, or silently return null embeddings. While the chunker targets 900 tokens, edge cases (dense code, base64, format prefixes) can produce chunks that exceed the context window. The reranker already had truncation logic; the embedding path did not. Changes: - Add truncateForEmbedding() in LlamaCpp that tokenizes and truncates text exceeding the 2048-token context window (minus 100 overhead) - Apply truncation in both embed() and embedBatch() before calling into node-llama-cpp, preventing SIGABRT and null results - Replace first-chunk dimension probing with a virtual probe text, decoupling dimension detection from user data - Add test/oversized-chunk.test.ts covering oversized single embed, mixed batch, and formatted chunks with titles Normal chunks (<=900 tokens) are unaffected -- truncation only activates on abnormally large inputs that would otherwise crash or be silently dropped. Fixes tobi#303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedding model (embeddinggemma-300M) has a 2048-token context window. Chunks exceeding this limit cause node-llama-cpp to crash with SIGABRT on Apple Silicon, or silently return null embeddings.
While the chunker targets 900 tokens, edge cases (dense code, base64, format prefixes) can produce chunks that exceed the context window. The reranker already had truncation logic; the embedding path did not.
Changes:
Normal chunks (<=900 tokens) are unaffected -- truncation only activates on abnormally large inputs that would otherwise crash or be silently dropped.
Fixes #303