-
Notifications
You must be signed in to change notification settings - Fork 92
If not targeting an architecture family don't run it's compiler #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
May want to hold off on this, I still get the error running: $ make TOCK_BOARD=nrf52840dk because Should it rather be removed from here: |
61b2658
to
c84283a
Compare
You can check
It'd be reasonable to add that to the config print from the verbose build to improve discoverability as part of this PR probably. Yes, |
c84283a
to
59ea614
Compare
Thanks, I used Yeah, I'll work on a patch for the nordic stuff that I can figure out, but I was really not sure what to do about imix especially the parts about the application address, so I'll probably just leave that alone and make a note of that in an issue. |
@@ -686,6 +688,7 @@ ifneq ($(V),) | |||
$(info MAKEFLAGS=$(MAKEFLAGS)) | |||
$(info PACKAGE_NAME=$(PACKAGE_NAME)) | |||
$(info TOCK_ARCHS=$(TOCK_ARCHS)) | |||
$(info TOCK_ARCH_FAMILIES=$(TOCK_ARCH_FAMILIES)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is apparently one more place to do this check in this configuration dump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ab7925a
59ea614
to
ab7925a
Compare
I figured I should also do the same for the |
This all looks good to me, thanks for the patches! |
This is related to #377, when running
One ends up getting a lot of messages if they don't have the riscv compiler installed,
make: riscv64-unknown-elf-gcc: No such file or directory
This appears to be because
Configuration.mk
runs the compiler to try and extract the compiler version.This patch tries to only run the compiler/extract the version if the
TOCK_TARGETS
contains the stringrv32
.I tested two cases:
TOCK_TARGETS="cortex-m4"
, ensuring it doesn't produce the errorTOCK_TARGETS
set, ensuring it still does because the default value contains the string.