Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: returning "true" instead of "void" #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: returning "true" instead of "void" #346

wants to merge 2 commits into from

Commits on Feb 15, 2022

  1. fix: returning "true" instead of "void" 

    Apparently process.kill() returns a Boolean, so the early return will
return a true||false rather than the void as per the func sig.

This patch ensures we return void regardless of what process.kill() and
process.exit() return. What they return may be dependent on node version
and/or platform.
    @berkes
    berkes committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    bc94223 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. fix: add an unreachable return, to test signal termination

    @berkes
    berkes committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    33b3367 View commit details
    Browse the repository at this point in the history