Explicitly define encoding of README.md#13
Open
brandon-avantus wants to merge 1 commit intotoddkarin:masterfrom
Open
Explicitly define encoding of README.md#13brandon-avantus wants to merge 1 commit intotoddkarin:masterfrom
brandon-avantus wants to merge 1 commit intotoddkarin:masterfrom
Conversation
Building the project on Windows fails unless the environment variable PYTHONUTF8=1 is set or the encoding is explicitly specified when opening README.md. The latter option allows pip installs to work as expected without requiring the environment variable.
Author
|
@toddkarin Any chance this could be merged soon? It's a tiny change that would allow the latest version of vocmax to be installed on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the project on Windows fails unless the environment variable PYTHONUTF8=1 is set or the encoding is explicitly specified when opening README.md. The latter option allows pip installs to work as expected without requiring the environment variable.
Fixes #12.