Skip to content

Conversation

@CompuIves
Copy link
Contributor

@CompuIves CompuIves commented Mar 14, 2025

For click v8, the behaviour of flags is a bit different than I expected. If the default is True, and you pass in that flag, it will invert (to False). The actual solution is this.

Context: https://stackoverflow.com/questions/53957389/how-does-python-click-library-handle-options-that-are-flags-and-true-by-default

Because of this, if you pass --wait to together endpoints create, it will actually not wait! Oops.


Note

Fix wait behavior by replacing --wait flags with --wait/--no-wait (default true) for endpoint create/start/stop commands.

  • CLI (endpoints):
    • Switch --wait to --wait/--no-wait with default True for create, start, and stop to ensure correct wait behavior.
    • Help text updated accordingly.

Written by Cursor Bugbot for commit ef4ee1d. This will update automatically on new commits. Configure here.

@CompuIves CompuIves requested a review from mojojoji March 14, 2025 12:52
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and experienced this as well! Thank you for the PR - I'll also be porting this over to our v2 library!

@blainekasten blainekasten merged commit 330157e into main Nov 26, 2025
12 checks passed
@blainekasten blainekasten deleted the fix/wait-flag branch November 26, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants