feat: Increase file size limit from 25GB to 50.1GB #396
+66
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-smetanin
left a comment
nikita-smetanin
left a comment
There was a problem hiding this comment.
Hi Soroush, PR looks nice, I left a few suggestions :)
|
|
||
| # Submit next part if available | ||
| if part_index < len(parts): | ||
| part_info = parts[part_index] |
There was a problem hiding this comment.
Would be great to rewrite it to deduplicate this code piece with the one above. I think you can either make a for loop to submit tasks and wait on result if we have enough already, or use executor.map with buffersize to limit concurrent tasks.
vorobyov01
approved these changes
Nov 17, 2025
|
Thanks for the PR, looks good to me! Please make sure to address this comment: |
nikita-smetanin
approved these changes
Nov 20, 2025
nikita-smetanin
left a comment
nikita-smetanin
left a comment
There was a problem hiding this comment.
Thanks for the changes! Let's ship it
src/together/filemanager.py
Outdated
| self._upload_single_part, part_info, part_data | ||
| ) | ||
| # Submit initial batch limited by max_concurrent_parts | ||
| for i in range(min(self.max_concurrent_parts, len(parts))): |
There was a problem hiding this comment.
I'd update it to while part_index < min(self.max_concurrent_parts, len(parts)): or at least replace i with _ as it's not used
sbassam
force-pushed
the
feat/increase-file-limit-to-50gb
branch
from
f3ba7c9 to
d104aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Issue #
Describe your changes
Clearly and concisely describe what's in this pull request. Include screenshots, if necessary.
Note
Increase file size limit to 50.1GB, bump multipart target part size to 250MB, add sliding-window concurrent uploads, add download timeout, and enhance file validation progress; tests updated accordingly.
TARGET_PART_SIZE_MBto250and file limitMAX_FILE_SIZE_GBto50.1._submit_parthelper; maintain max concurrency via executor; progress tracked withtqdm.request_timeout=3600to streamed downloads._check_utf8.tqdmprogress to JSONL validation loop.as_completedmocking for sliding-window logic.Written by Cursor Bugbot for commit d104aa1. This will update automatically on new commits. Configure here.