feat(authentication): Added login, routes and navigation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crsstha
force-pushed
the
feat/authentication
branch
from
d340621 to
0790b17
Compare
AdityaKhatri
requested changes
Jan 6, 2026
| <Button | ||
| name="logout" | ||
| variant="tertiary" | ||
| className={styles.dropdownOption} |
There was a problem hiding this comment.
disable button when fetching. Change variable name to logoutPending
Comment on lines
+28
to
+32
| const toggleAccordion = (index: number) => { | ||
| setOpenIndexes((prev) => (prev.includes(index) | ||
| ? prev.filter((i) => i !== index) | ||
| : [...prev, index])); | ||
| }; |
| type="button" | ||
| className={styles.navHeaderContainer} | ||
| childrenContainerClassName={styles.navHeader} | ||
| onClick={() => toggleAccordion(index)} |
There was a problem hiding this comment.
Suggested change
| onClick={() => toggleAccordion(index)} | |
| onClick={toggleAccordion} |
| )} | ||
| > | ||
| <Button | ||
| name={item.title} |
There was a problem hiding this comment.
Suggested change
| name={item.title} | |
| name={index} |
|
|
||
| } | ||
| function Navigation({ navigationItem }: { navigationItem: NavigationItem[] }) { | ||
| const [openIndexes, setOpenIndexes] = useState( |
There was a problem hiding this comment.
instead of open indexes can we use the name of the button? or the link?
| import UserContext from '#contexts/UserContext'; | ||
| import { useLoginMutation } from '#generated/types/graphql'; | ||
|
|
||
| import banner from '../../resources/image/redCrossBanner.png'; |
There was a problem hiding this comment.
add new absolute route for resources
|
|
||
| const error = getErrorObject(formError); | ||
|
|
||
| const [{ fetching }, triggerLogin] = useLoginMutation(); |
There was a problem hiding this comment.
Suggested change
| const [{ fetching }, triggerLogin] = useLoginMutation(); | |
| const [{ loginPending }, triggerLogin] = useLoginMutation(); |
| }); | ||
| navigate('/'); | ||
| } else { | ||
| setError({ email: 'Failed to login!' }); |
| <Image src={banner} /> | ||
| <form | ||
| className={styles.loginForm} | ||
| onSubmit={(e) => { e.preventDefault(); handleFormSubmit(); }} |
There was a problem hiding this comment.
add a separate handler instead of having inline functions. Avoid inlines as much as possible.
| .leftPane { | ||
| display: flex; | ||
| flex-direction: column; | ||
| box-shadow: 0px 4px 4px 0px rgba(227, 227, 227, 0.25); |
There was a problem hiding this comment.
avoid this if possible. If not, then its fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any
console.logmeant for debuggingThis PR includes