Fix newly added clippy warning #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
warning: the following explicit lifetimes could be elided: 'a
--> async-stream/src/yielder.rs:90:6
|
90 | impl<'a, T> Drop for Enter<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
90 - impl<'a, T> Drop for Enter<'a, T> {
90 + impl<T> Drop for Enter<'_, T> {
|
warning: the following explicit lifetimes could be elided: 'a
--> async-stream/tests/stream.rs:164:19
|
164 | fn stream<'a>(&'a self) -> impl Stream<Item = &str> + 'a {
| ^^ ^^ ^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
164 - fn stream<'a>(&'a self) -> impl Stream<Item = &str> + 'a {
164 + fn stream(&self) -> impl Stream<Item = &str> + '_ {
|
```
Darksonn
approved these changes
Dec 8, 2024
| impl<'a, T> Drop for Enter<'a, T> { | ||
| impl<T> Drop for Enter<'_, T> { |
There was a problem hiding this comment.
I disagree with the warning in this case. :(
There was a problem hiding this comment.
Well, this is what is also covered in single_use_lifetimes (which is allowed by default), so maybe clippy::needless_lifetimes should not warn it.
warning: lifetime parameter `'a` only used once
--> src/lib.rs:7:6
|
7 | impl<'a, T> Drop for Enter<'a, T> {
| ^^ this lifetime... -- ...is used only here
|
note: the lint level is defined here
--> src/lib.rs:1:9
|
1 | #![warn(single_use_lifetimes)]
| ^^^^^^^^^^^^^^^^^^^^
help: elide the single-use lifetime
|
7 - impl<'a, T> Drop for Enter<'a, T> {
7 + impl<T> Drop for Enter<'_, T> {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes clippy warning added in Rust 1.83.
See commit message for the content of warning.