Skip to content

Update CI workflow link in README #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

GuroChil
Copy link

Changes made:
File: axum-core/README.md

Reason for changes:
Updating the CI workflow link to point to the correct location in the main repository's .github/workflows directory. The old link was pointing to a non-existent path.

If there's a more appropriate or preferred link for the CI workflow, please let me know and I'll update the PR accordingly.

@jplatte
Copy link
Member

jplatte commented Jun 24, 2025

I don't really know why we have CI badges to begin with. GitHub shows the CI status on each commit in the history.

I'd prefering removing this and any others we have. Thoughts @yanns @mladedav @Turbo87 ?

@mladedav
Copy link
Collaborator

When they're available, I sometimes use e.g. the crates.io one as a hyperlink to get to the crate's page. So I'd be personally in favor of getting rid of the CI (unless someone has a usage for it) but I'd rather keep the others, though I don't feel strongly about it.

@GuroChil how did you find the broken link, did you try to use it for some purpose or were you just hunting specifically for broken links to fix (I noticed you opened similar PRs in tracing at the same time)

@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 25, 2025

fully agree, IMHO they're just unnecessary noise at this point

@jplatte
Copy link
Member

jplatte commented Jun 25, 2025

@mladedav I was specifically taking about CI badges, I've also found other badges useful (though haven't clicked on in a long time).

@mladedav
Copy link
Collaborator

Ah, sorry, I must have misinterpreted the "remove this and any others we have", I thought you were talking about all of the badges. In that case I agree.

@jplatte
Copy link
Member

jplatte commented Jun 25, 2025

Ah yeah, I was just taking about CI badges in any of the other readme files.

@yanns
Copy link
Collaborator

yanns commented Jun 25, 2025

I don't use this link. It can be removed IMO.

@jplatte
Copy link
Member

jplatte commented Jun 27, 2025

@GuroChil want to update this PR to delete the CI badges from axum, axum-core, axum-extra and axum-macros' README.mds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants