Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary custom clap value parser #147

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Remove unnecessary custom clap value parser #147

merged 1 commit into from
Aug 3, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Aug 2, 2024

clap can use the appropriate From trait of the value type.

https://docs.rs/clap/4.5.13/clap/macro.value_parser.html

Darksonn
Darksonn approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit e186482 into tokio-rs:master Aug 3, 2024
1 check passed
@tottoto tottoto deleted the remove-unnecessary-custom-clap-value-parser branch August 3, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @Darksonn