Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefix macro calls with ::core to avoid clashing with local macros #3024

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix: prefix macro calls with ::core to avoid clashing with local macros #3024

merged 3 commits into from
Jul 24, 2024

Commits on Jun 30, 2024

  1. fix: prefix macro calls with ::core to avoid clashing with local macros 

    This commit fixes a bug where a macro call to macros defined in the
standard lib from the `tracing` and `tracing-core` crates could be
resolved to a local macro with the same name, causing a compilation
error. This commit prefixes these calls with `::core::` to ensure that
they are resolved to the standard library macros.

Fixes: <tokio-rs#3023>
    @joshka
    joshka committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f1ab24e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. fix: use __macro_support:: instead of ::core:: in macros 

    This ensures that the tracing lib correctly builds when a crate is named
`core`. See tokio-rs#2761 and
tokio-rs#2762 for more info.
    @joshka
    joshka committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5960e0a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'master' into jm/fix-macro-disambiguation

    @davidbarsky
    davidbarsky authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b4c1a68 View commit details
    Browse the repository at this point in the history