Implement Ord and PartialOrd for span ID#3472
Open
soumyasen1809 wants to merge 3 commits intotokio-rs:mainfrom
Open
Implement Ord and PartialOrd for span ID#3472soumyasen1809 wants to merge 3 commits intotokio-rs:mainfrom
soumyasen1809 wants to merge 3 commits intotokio-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3462
Motivation
This change implements
OrdandPartialOrdfor the span::Id type in the tracing-core crate. Currently, span::Id only implements Eq, PartialEq, and Hash. Without Ord, subscriber implementations cannot store span IDs in ordered collections like BTreeMap or BTreeSet.Fixes issue #3462.
Solution
Added PartialOrd and Ord traits to the
Idstruct.