Skip to content

implement valuable for Path #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement valuable for Path #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/tests/ui/not_valuable.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
&T
&[T]
&mut T
&std::path::Path
&str
()
(T0, T1)
(T0, T1, T2)
(T0, T1, T2, T3)
and $N others
= note: required for `Option<S>` to implement `Valuable`

Expand All @@ -31,11 +31,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
&T
&[T]
&mut T
&std::path::Path
&str
()
(T0, T1)
(T0, T1, T2)
(T0, T1, T2, T3)
and $N others
= note: required for `Option<S>` to implement `Valuable`

Expand All @@ -52,11 +52,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
&T
&[T]
&mut T
&std::path::Path
&str
()
(T0, T1)
(T0, T1, T2)
(T0, T1, T2, T3)
and $N others
= note: required for `Option<S>` to implement `Valuable`
= note: 1 redundant requirement hidden
Expand All @@ -75,11 +75,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
&T
&[T]
&mut T
&std::path::Path
&str
()
(T0, T1)
(T0, T1, T2)
(T0, T1, T2, T3)
and $N others
= note: required for `Option<S>` to implement `Valuable`
= note: 1 redundant requirement hidden
Expand Down
2 changes: 1 addition & 1 deletion valuable/src/valuable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ impl Valuable for alloc::string::String {
}

#[cfg(feature = "std")]
impl Valuable for &std::path::Path {
impl Valuable for std::path::Path {
fn as_value(&self) -> Value<'_> {
Value::Path(self)
}
Expand Down