Fixed bug with rejection on ios #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all! Really appreciate your work on this. Any idea when the PR will be approved by second proxy, merged and released? We are waiting on this same issue on a project. Thank you |
|
Paystack how does this take eternity, some of us have clients! This is so unfair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @tolu360 , good job with this project!
There is a bug around
cardParamsAreValidblock when a charge is attempted with invalid card details, and expected error is thrown, subsequent trials always returnAnother request is still being processed, please wait. It is caused becauserequestIsCompletedwas not updated when the initial error was thrown; this PR fixes that.This may in part fix #38 (comment)
Cheers! :)