Skip to content

Fix undefined indexes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clesquir wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined indexes #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ function p2pSocket (socket, next, room) {
delete clients[socket.id]
Object.keys(connectedClients).forEach(function (clientId, i) {
var client = clients[clientId]
client.emit('peer-disconnect', {peerId: socket.id})
if (client) {
client.emit('peer-disconnect', {peerId: socket.id})
}
})
debug('Client gone (id=' + socket.id + ').')
})
Expand All @@ -28,9 +30,11 @@ function p2pSocket (socket, next, room) {
var client = clients[clientId]
if (client !== socket) {
var offerObj = data.offers[i]
var emittedOffer = {fromPeerId: socket.id, offerId: offerObj.offerId, offer: offerObj.offer}
debug('Emitting offer: %s', JSON.stringify(emittedOffer))
client.emit('offer', emittedOffer)
if (offerObj) {
var emittedOffer = {fromPeerId: socket.id, offerId: offerObj.offerId, offer: offerObj.offer}
debug('Emitting offer: %s', JSON.stringify(emittedOffer))
client.emit('offer', emittedOffer)
}
}
})
})
Expand All @@ -39,7 +43,9 @@ function p2pSocket (socket, next, room) {
var toPeerId = data.toPeerId
debug('Signal peer id %s', toPeerId);
var client = clients[toPeerId]
client.emit('peer-signal', data)
if (client) {
client.emit('peer-signal', data)
}
})
typeof next === 'function' && next()
}